From: Marc Mutz <marc.mutz@kdab.com>
Date: Tue, 28 Feb 2012 21:06:36 +0000 (+0100)
Subject: QPair: remove user-defined copy assignment operator
X-Git-Tag: qt-v5.0.0-alpha1~688
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a82f78dea36c297b5a4a44853936cc733de8197;p=profile%2Fivi%2Fqtbase.git

QPair: remove user-defined copy assignment operator

The compiler-generated copy assignment operator is fine,
and the user-defined one prevents the compiler from
synthesising a move assignment operator.

Change-Id: I044104a2fd4d7522a910d5c2a68d11dabeca99c4
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
---

diff --git a/src/corelib/tools/qpair.h b/src/corelib/tools/qpair.h
index 501f2af..064a750 100644
--- a/src/corelib/tools/qpair.h
+++ b/src/corelib/tools/qpair.h
@@ -57,9 +57,7 @@ struct QPair
 
     QPair() : first(T1()), second(T2()) {}
     QPair(const T1 &t1, const T2 &t2) : first(t1), second(t2) {}
-
-    QPair<T1, T2> &operator=(const QPair<T1, T2> &other)
-    { first = other.first; second = other.second; return *this; }
+    // compiler-generated copy/move ctor/assignment operators are fine!
 
     T1 first;
     T2 second;