From: Chao Yu <yuchao0@huawei.com>
Date: Wed, 5 Sep 2018 06:54:02 +0000 (+0800)
Subject: f2fs: fix memory leak of percpu counter in fill_super()
X-Git-Tag: v5.4-rc1~2390^2~51
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a70e255449c9a13eed7a6eeecc85a1ea63cef76;p=platform%2Fkernel%2Flinux-rpi.git

f2fs: fix memory leak of percpu counter in fill_super()

In fill_super -> init_percpu_info, we should destroy percpu counter
in error path, otherwise memory allcoated for percpu counter will
leak.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2f55713..b2acb7f 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2458,8 +2458,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi)
 	if (err)
 		return err;
 
-	return percpu_counter_init(&sbi->total_valid_inode_count, 0,
+	err = percpu_counter_init(&sbi->total_valid_inode_count, 0,
 								GFP_KERNEL);
+	if (err)
+		percpu_counter_destroy(&sbi->alloc_valid_block_count);
+
+	return err;
 }
 
 #ifdef CONFIG_BLK_DEV_ZONED