From: Roel Kluin <roel.kluin@gmail.com>
Date: Fri, 18 Dec 2009 11:38:11 +0000 (+0100)
Subject: drbd: fix test of unsigned in _drbd_fault_random()
X-Git-Tag: 2.1b_release~9802^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a63b030d75a063b910b2bab014d84837cb33eb7;p=platform%2Fkernel%2Fkernel-mfld-blackbay.git

drbd: fix test of unsigned in _drbd_fault_random()

rsp->count is unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 157d1e4..c2594c1 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -3623,7 +3623,7 @@ _drbd_fault_random(struct fault_random_state *rsp)
 {
 	long refresh;
 
-	if (--rsp->count < 0) {
+	if (!rsp->count--) {
 		get_random_bytes(&refresh, sizeof(refresh));
 		rsp->state += refresh;
 		rsp->count = FAULT_RANDOM_REFRESH;