From: H Hartley Sweeten Date: Tue, 26 Nov 2013 23:42:10 +0000 (-0700) Subject: staging: comedi: mpc624: remove unnecessary printk noise X-Git-Tag: v3.14-rc1~13^2~615 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a4ed3f96bc125f376d83f3d29aef6bb2780c10b;p=kernel%2Fkernel-generic.git staging: comedi: mpc624: remove unnecessary printk noise The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. It's also not necessary to set data[n[ = 0 when the read timesout. Remove that also. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/mpc624.c b/drivers/staging/comedi/drivers/mpc624.c index b105dd9..01b281e 100644 --- a/drivers/staging/comedi/drivers/mpc624.c +++ b/drivers/staging/comedi/drivers/mpc624.c @@ -177,11 +177,9 @@ static int mpc624_ai_rinsn(struct comedi_device *dev, else break; } - if (i == TIMEOUT) { - printk(KERN_ERR "MPC624: timeout (%dms)\n", TIMEOUT); - data[n] = 0; + if (i == TIMEOUT) return -ETIMEDOUT; - } + /* Start reading data */ data_in = 0; data_out = devpriv->ulConvertionRate;