From: fpizlo@apple.com Date: Wed, 27 Jun 2012 21:45:08 +0000 (+0000) Subject: x86 disassembler confuses immediates with addresses X-Git-Tag: 070512121124~513 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a4978bd468c77cb425403b7d0ac31d1335e3855;p=profile%2Fivi%2Fwebkit-efl.git x86 disassembler confuses immediates with addresses https://bugs.webkit.org/show_bug.cgi?id=90099 Reviewed by Mark Hahnenberg. Prepend "$" to immediates to disambiguate between immediates and addresses. This is in accordance with the gas and AT&T syntax. * disassembler/udis86/udis86_syn-att.c: (gen_operand): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121374 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog index b74cef7..88dc4d0 100644 --- a/Source/JavaScriptCore/ChangeLog +++ b/Source/JavaScriptCore/ChangeLog @@ -1,5 +1,18 @@ 2012-06-27 Filip Pizlo + x86 disassembler confuses immediates with addresses + https://bugs.webkit.org/show_bug.cgi?id=90099 + + Reviewed by Mark Hahnenberg. + + Prepend "$" to immediates to disambiguate between immediates and addresses. This is in + accordance with the gas and AT&T syntax. + + * disassembler/udis86/udis86_syn-att.c: + (gen_operand): + +2012-06-27 Filip Pizlo + Add a comment clarifying Options::showDisassembly versus Options::showDFGDisassembly. Rubber stamped by Mark Hahnenberg. diff --git a/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c b/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c index 132d6ff..155a34c 100644 --- a/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c +++ b/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c @@ -109,7 +109,7 @@ gen_operand(struct ud* u, struct ud_operand* op) } if ( sext_size < 64 ) sext_mask = ( 1ull << sext_size ) - 1; - mkasm( u, "0x" FMT64 "x", imm & sext_mask ); + mkasm( u, "$0x" FMT64 "x", imm & sext_mask ); break; }