From: Christopher Michael <cp.michael@samsung.com>
Date: Thu, 2 May 2019 12:11:27 +0000 (+0200)
Subject: eina_test_strbuf: Fix resource leak
X-Git-Tag: accepted/tizen/unified/20190509.041000~43
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a3c17dde2fd303a36aadf7ae83ae23d781925e4;p=platform%2Fupstream%2Fefl.git

eina_test_strbuf: Fix resource leak

Summary:
Coverity reports that we leak storage that 'buf' points to because we
are reassigning the variable, so lets free the previous strbuf so we
don't leak.

Fixes CID1400952

@fix

Depends on D8769

Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8770
---

diff --git a/src/tests/eina/eina_test_strbuf.c b/src/tests/eina/eina_test_strbuf.c
index a308374..67f3044 100644
--- a/src/tests/eina/eina_test_strbuf.c
+++ b/src/tests/eina/eina_test_strbuf.c
@@ -630,7 +630,6 @@ EFL_START_TEST(eina_test_strbuf_strftime_test)
    fail_if(str == NULL || strcmp(str, cbuf) != 0);
    eina_strbuf_reset(buf);
 
-   buf = eina_strbuf_new();
    eina_strbuf_append(buf, "Hours: Minutes");
    eina_strbuf_prepend_strftime(buf, "%I ", info);
    eina_strbuf_insert_strftime(buf, "%M ", info, 10);