From: Dan Carpenter <error27@gmail.com>
Date: Wed, 27 Jul 2011 09:58:17 +0000 (+0300)
Subject: iscsi-target: Fix NULL dereference on allocation failure
X-Git-Tag: v3.1-rc1~41^2~9
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a28a3fa8c37193b105807193b3695048f0050a4;p=profile%2Fivi%2Fkernel-x86-ivi.git

iscsi-target: Fix NULL dereference on allocation failure

This patch fixes a bug in iscsi_target_init_negotiation() where
the "goto out" path dereferences "login" which is NULL upon a
memory allocation failure.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 713a4d2..4d087ac 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -978,7 +978,7 @@ struct iscsi_login *iscsi_target_init_negotiation(
 		pr_err("Unable to allocate memory for struct iscsi_login.\n");
 		iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
 				ISCSI_LOGIN_STATUS_NO_RESOURCES);
-		goto out;
+		return NULL;
 	}
 
 	login->req = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL);