From: Yang Yingliang Date: Tue, 6 Apr 2021 13:50:53 +0000 (+0200) Subject: media: i2c: adv7842: fix possible use-after-free in adv7842_remove() X-Git-Tag: v5.15~1266^2~45 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a15275b6a18597079f18241c87511406575179a;p=platform%2Fkernel%2Flinux-starfive.git media: i2c: adv7842: fix possible use-after-free in adv7842_remove() This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This means that the callback function may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that the work is properly cancelled, no longer running, and unable to re-schedule itself. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 21dbb7a..8bd58ce0 100644 --- a/drivers/media/i2c/adv7842.c +++ b/drivers/media/i2c/adv7842.c @@ -3573,7 +3573,7 @@ static int adv7842_remove(struct i2c_client *client) struct adv7842_state *state = to_state(sd); adv7842_irq_enable(sd, false); - cancel_delayed_work(&state->delayed_work_enable_hotplug); + cancel_delayed_work_sync(&state->delayed_work_enable_hotplug); v4l2_device_unregister_subdev(sd); media_entity_cleanup(&sd->entity); adv7842_unregister_clients(sd);