From: Nicolas de Pesloüan Date: Wed, 7 Oct 2009 21:11:00 +0000 (-0700) Subject: bonding: remove useless assignment X-Git-Tag: v3.12-rc1~12159^2~884 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=49b4ad92d1a5bb9909deb3216ffec6f0febc7b71;p=kernel%2Fkernel-generic.git bonding: remove useless assignment The variable old_active is first set to bond->curr_active_slave. Then, it is unconditionally set to new_active, without being used in between. The first assignment, having no side effect, is useless. Signed-off-by: Nicolas de Pesloüan Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller --- diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 05877cb..ef6af1c 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1119,7 +1119,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond) int mintime = bond->params.updelay; int i; - new_active = old_active = bond->curr_active_slave; + new_active = bond->curr_active_slave; if (!new_active) { /* there were no active slaves left */ if (bond->slave_cnt > 0) /* found one slave */