From: Peter Hurley <peter@hurleysoftware.com>
Date: Wed, 28 Nov 2012 02:37:12 +0000 (-0500)
Subject: staging/fwserial: Use WARN_ONCE when port table is corrupted
X-Git-Tag: v3.8-rc1~177^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=49b2746e1426ffa188421996a0323bdd47657108;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git

staging/fwserial: Use WARN_ONCE when port table is corrupted

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index 99a2d2d..0681967 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -939,14 +939,9 @@ static void fwserial_destroy(struct kref *kref)
 
 	mutex_lock(&port_table_lock);
 	for (j = 0; j < num_ports; ++i, ++j) {
-		static bool once;
-		int corrupt = port_table[i] != ports[j];
-		if (corrupt && !once) {
-			WARN(corrupt, "port_table[%d]: %p != ports[%d]: %p",
-			     i, port_table[i], j, ports[j]);
-			once = true;
-			port_table_corrupt = true;
-		}
+		port_table_corrupt |= port_table[i] != ports[j];
+		WARN_ONCE(port_table_corrupt, "port_table[%d]: %p != ports[%d]: %p",
+		     i, port_table[i], j, ports[j]);
 
 		port_table[i] = NULL;
 	}