From: Vincent Whitchurch Date: Thu, 9 Jun 2022 14:17:04 +0000 (+0200) Subject: tty: goldfish: Fix free_irq() on remove X-Git-Tag: v6.1-rc5~1060^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=499e13aac6c762e1e828172b0f0f5275651d6512;p=platform%2Fkernel%2Flinux-starfive.git tty: goldfish: Fix free_irq() on remove Pass the correct dev_id to free_irq() to fix this splat when the driver is unbound: WARNING: CPU: 0 PID: 30 at kernel/irq/manage.c:1895 free_irq Trying to free already-free IRQ 65 Call Trace: warn_slowpath_fmt free_irq goldfish_tty_remove platform_remove device_remove device_release_driver_internal device_driver_detach unbind_store drv_attr_store ... Fixes: 465893e18878e119 ("tty: goldfish: support platform_device with id -1") Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20220609141704.1080024-1-vincent.whitchurch@axis.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index c7968ae..d02de3f 100644 --- a/drivers/tty/goldfish.c +++ b/drivers/tty/goldfish.c @@ -426,7 +426,7 @@ static int goldfish_tty_remove(struct platform_device *pdev) tty_unregister_device(goldfish_tty_driver, qtty->console.index); iounmap(qtty->base); qtty->base = NULL; - free_irq(qtty->irq, pdev); + free_irq(qtty->irq, qtty); tty_port_destroy(&qtty->port); goldfish_tty_current_line_count--; if (goldfish_tty_current_line_count == 0)