From: yongsung1.kim Date: Thu, 25 Jul 2013 00:51:08 +0000 (+0900) Subject: [Title] remove sonar critical X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4995d44d752358b2699a96f5e1129ee1ff825a86;p=sdk%2Finstaller%2Finstall-manager.git [Title] remove sonar critical [Issue] Change-Id: I2a92452bbae2fe050c6664d191532acb7413ea9d --- diff --git a/InstallManager_java/src/org/tizen/installmanager/core/Installer.java b/InstallManager_java/src/org/tizen/installmanager/core/Installer.java index 1f9a19b..8a9da6d 100644 --- a/InstallManager_java/src/org/tizen/installmanager/core/Installer.java +++ b/InstallManager_java/src/org/tizen/installmanager/core/Installer.java @@ -164,34 +164,34 @@ public class Installer { return true; } - private boolean moveInstallScript(String tempDir, Package pack) { - // move removeScript file to special Directory - File installScriptFrom = new File(tempDir + File.separator - + pack.getInstallScript()); - - if ((pack.getInstallScript() != null) - && !(pack.getInstallScript().equals("")) - && (installScriptFrom.exists())) { - File installScriptTo = new File(getInstallScriptLocalPath(pack)); - if (!createInstallScriptDir(installScriptTo)) { - Log.err("Cannot create install script directory in Info directory => " - + pack.getPackageName()); - return false; - } else { - if (installScriptTo.exists()) { - if (!installScriptTo.delete()) { - Log.err("Fail to delete file ==> " + installScriptTo); - } - } - if (!PathUtil.moveFile(installScriptFrom, installScriptTo)) { - Log.err("Cannot move install Script to targetDir => " - + pack.getPackageName()); - return false; - } - } - } - return true; - } +// private boolean moveInstallScript(String tempDir, Package pack) { +// // move removeScript file to special Directory +// File installScriptFrom = new File(tempDir + File.separator +// + pack.getInstallScript()); +// +// if ((pack.getInstallScript() != null) +// && !(pack.getInstallScript().equals("")) +// && (installScriptFrom.exists())) { +// File installScriptTo = new File(getInstallScriptLocalPath(pack)); +// if (!createInstallScriptDir(installScriptTo)) { +// Log.err("Cannot create install script directory in Info directory => " +// + pack.getPackageName()); +// return false; +// } else { +// if (installScriptTo.exists()) { +// if (!installScriptTo.delete()) { +// Log.err("Fail to delete file ==> " + installScriptTo); +// } +// } +// if (!PathUtil.moveFile(installScriptFrom, installScriptTo)) { +// Log.err("Cannot move install Script to targetDir => " +// + pack.getPackageName()); +// return false; +// } +// } +// } +// return true; +// } /** * @param pack diff --git a/InstallManager_java/src/org/tizen/installmanager/ui/page/ViewController.java b/InstallManager_java/src/org/tizen/installmanager/ui/page/ViewController.java index 0432e97..bde25a0 100644 --- a/InstallManager_java/src/org/tizen/installmanager/ui/page/ViewController.java +++ b/InstallManager_java/src/org/tizen/installmanager/ui/page/ViewController.java @@ -29,12 +29,7 @@ package org.tizen.installmanager.ui.page; import java.io.File; -import java.io.FileNotFoundException; import java.io.IOException; -import java.io.RandomAccessFile; -import java.nio.channels.FileChannel; -import java.nio.channels.FileLock; -import java.nio.channels.OverlappingFileLockException; import java.util.ArrayList; import java.util.Collection; import java.util.List; @@ -85,9 +80,6 @@ public class ViewController { private InstallManager installManager; private PackageManager packageManager; private SDKExtensionInfo sdkExtensionInfo; - - private FileLock lock = null; - private FileChannel channel = null; /** * Initialize objects which need to install.