From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Tue, 28 Sep 2010 14:14:14 +0000 (+0200)
Subject: frei0r: Fix crashes if plugins don't provide correct property information
X-Git-Tag: 1.19.3~507^2~16404
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=498620d16c8661d216c45694622c540cfb838b90;p=platform%2Fupstream%2Fgstreamer.git

frei0r: Fix crashes if plugins don't provide correct property information

The vertigo plugin for example claims to have 3 properties but
the 3rd property does nothing and has a NULL name.

Fixes bug #630783.

Thanks to Martti Kühne for debugging this.
---

diff --git a/gst/frei0r/gstfrei0r.c b/gst/frei0r/gstfrei0r.c
index 2254dc2..6b8c008 100644
--- a/gst/frei0r/gstfrei0r.c
+++ b/gst/frei0r/gstfrei0r.c
@@ -72,6 +72,12 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
 
     ftable->get_param_info (param_info, i);
 
+    if (!param_info->name) {
+      GST_ERROR ("Property %d of %s without a valid name", i,
+          g_type_name (G_TYPE_FROM_CLASS (gobject_class)));
+      continue;
+    }
+
     prop_name = g_ascii_strdown (param_info->name, -1);
     g_strcanon (prop_name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "-+", '-');
     /* satisfy glib2 (argname[0] must be [A-Za-z]) */