From: Tim-Philipp Müller Date: Mon, 15 Aug 2011 20:05:34 +0000 (+0100) Subject: caps: fix compiler warning reported by ICC X-Git-Tag: RELEASE-0.10.36~214 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4985d2a954b293e56d670d10e2448ddd52d574d2;p=platform%2Fupstream%2Fgstreamer.git caps: fix compiler warning reported by ICC The MAX macro expands to code that checks if an unsigned integer is < 0. Fixes warning #186: pointless comparison of unsigned integer reported by ICC. https://bugzilla.gnome.org/show_bug.cgi?id=656265 --- diff --git a/gst/gstcaps.c b/gst/gstcaps.c index df348be..94b7000 100644 --- a/gst/gstcaps.c +++ b/gst/gstcaps.c @@ -1239,7 +1239,7 @@ gst_caps_can_intersect (const GstCaps * caps1, const GstCaps * caps2) j = MIN (i, len1 - 1); /* subset index stays 0 until i reaches superset->structs->len, then it * counts up from 1 to subset->structs->len - 1 */ - k = MAX (0, i - j); + k = (i > j) ? (i - j) : 0; /* MAX (0, i - j) */ /* now run the diagonal line, end condition is the left or bottom * border */ @@ -1310,7 +1310,7 @@ gst_caps_intersect_zig_zag (const GstCaps * caps1, const GstCaps * caps2) j = MIN (i, len1 - 1); /* caps2 index stays 0 until i reaches caps1->structs->len, then it counts * up from 1 to caps2->structs->len - 1 */ - k = MAX (0, i - j); + k = (i > j) ? (i - j) : 0; /* MAX (0, i - j) */ /* now run the diagonal line, end condition is the left or bottom * border */