From: Heinrich Schuchardt Date: Tue, 23 Aug 2022 08:31:56 +0000 (+0200) Subject: boot: simplify bootmeth_vbe_simple_ft_fixup() X-Git-Tag: v2022.10~36^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=49740e02555f72394fb319a8221bad833d8207db;p=platform%2Fkernel%2Fu-boot.git boot: simplify bootmeth_vbe_simple_ft_fixup() Don't assign a value to a variable if it is not used afterwards. Move variables to the code fragment where they are used. Addresses-Coverity: CID 356243 ("Code maintainability issues (UNUSED_VALUE)") Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- diff --git a/boot/vbe_simple.c b/boot/vbe_simple.c index a395bc20a6..0fc57388f3 100644 --- a/boot/vbe_simple.c +++ b/boot/vbe_simple.c @@ -225,17 +225,16 @@ static int bootmeth_vbe_simple_ft_fixup(void *ctx, struct event *event) { oftree tree = event->data.ft_fixup.tree; struct udevice *dev; - ofnode node; - int ret; /* * Ideally we would have driver model support for fixups, but that does * not exist yet. It is a step too far to try to do this before VBE is * in place. */ - for (ret = vbe_find_first_device(&dev); dev; - ret = vbe_find_next_device(&dev)) { + for (vbe_find_first_device(&dev); dev; vbe_find_next_device(&dev)) { struct simple_state state; + ofnode node; + int ret; if (strcmp("vbe_simple", dev->driver->name)) continue;