From: BoxiLiu Date: Wed, 30 Oct 2013 12:07:20 +0000 (-0400) Subject: ext4: change ext4_read_inline_dir() to return 0 on success X-Git-Tag: upstream/snapshot3+hdmi~3975^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=48ffdab1c1eb87fee9ed7366472e2b9aa4577a60;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ext4: change ext4_read_inline_dir() to return 0 on success In ext4_read_inline_dir(), if there is inline data, the successful return value is the return value of ext4_read_inline_data(). Howewer, this is used by ext4_readdir(), and while it seems harmless to return a positive value on success, it's inconsistent, since historically we've always return 0 on success. Signed-off-by: BoxiLiu Signed-off-by: "Theodore Ts'o" Acked-by: Tao Ma --- diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index d9ecbf1..c3efb65 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1442,6 +1442,7 @@ int ext4_read_inline_dir(struct file *file, if (ret < 0) goto out; + ret = 0; sb = inode->i_sb; parent_ino = le32_to_cpu(((struct ext4_dir_entry_2 *)dir_buf)->inode); offset = ctx->pos;