From: Pavel Begunkov Date: Wed, 15 Jun 2022 16:33:52 +0000 (+0100) Subject: io_uring: explain io_wq_work::cancel_seq placement X-Git-Tag: v6.1-rc5~771^2~109 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=48c13d8980840e489a537e4af4b2503eb9d8a1ec;p=platform%2Fkernel%2Flinux-starfive.git io_uring: explain io_wq_work::cancel_seq placement Add a comment on why we keep ->cancel_seq in struct io_wq_work instead of struct io_kiocb despite it needed only by io_uring but not io-wq. Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/988e87eec9dc700b5dae933df3aefef303502f6c.1655310733.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- diff --git a/io_uring/io-wq.h b/io_uring/io-wq.h index ba6eee7..3f54ee2 100644 --- a/io_uring/io-wq.h +++ b/io_uring/io-wq.h @@ -155,6 +155,7 @@ struct io_wq_work_node *wq_stack_extract(struct io_wq_work_node *stack) struct io_wq_work { struct io_wq_work_node list; unsigned flags; + /* place it here instead of io_kiocb as it fills padding and saves 4B */ int cancel_seq; };