From: Namjae Jeon <linkinjeon@kernel.org>
Date: Fri, 12 May 2023 08:05:41 +0000 (+0900)
Subject: ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename()
X-Git-Tag: v6.6.7~2753^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=48b47f0caaa8a9f05ed803cb4f335fa3a7bfc622;p=platform%2Fkernel%2Flinux-starfive.git

ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename()

Uninitialized rd.delegated_inode can be used in vfs_rename().
Fix this by setting rd.delegated_inode to NULL to avoid the uninitialized
read.

Fixes: 74d7970febf7 ("ksmbd: fix racy issue from using ->d_parent and ->d_name")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index 778c152..9bdb01c 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -743,6 +743,7 @@ retry:
 	rd.new_dir		= new_path.dentry->d_inode,
 	rd.new_dentry		= new_dentry,
 	rd.flags		= flags,
+	rd.delegated_inode	= NULL,
 	err = vfs_rename(&rd);
 	if (err)
 		ksmbd_debug(VFS, "vfs_rename failed err %d\n", err);