From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Date: Tue, 23 Mar 2010 04:23:50 +0000 (+0000)
Subject: ksz884x: fix return value of netdev_set_eeprom
X-Git-Tag: v3.0~5043^2~175
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4881a4f89a95cc5fef6d32953954bcc3443eefd5;p=platform%2Fkernel%2Flinux-amlogic.git

ksz884x: fix return value of netdev_set_eeprom

ksz884x: fix return value of netdev_set_eeprom

netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.

Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 0f59099..6c5327a 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_device *dev,
 	int len;
 
 	if (eeprom->magic != EEPROM_MAGIC)
-		return 1;
+		return -EINVAL;
 
 	len = (eeprom->offset + eeprom->len + 1) / 2;
 	for (i = eeprom->offset / 2; i < len; i++)