From: Lars-Peter Clausen Date: Thu, 16 Dec 2021 18:52:08 +0000 (+0100) Subject: iio: ad9523: Use sysfs_emit() X-Git-Tag: v6.6.17~7878^2~55^2~208 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=48788715ac8ed610a3d30ef1fb8d7fd38bdc1f81;p=platform%2Fkernel%2Flinux-rpi.git iio: ad9523: Use sysfs_emit() sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it knows about the sysfs buffer specifics and has some built-in checks for size and alignment. Use sysfs_emit() to format the custom device attributes of the ad9523 driver. Signed-off-by: Lars-Peter Clausen Link: https://lore.kernel.org/r/20211216185217.1054495-5-lars@metafoo.de Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index bdb0bc3..a0f92c3 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -551,7 +551,7 @@ static ssize_t ad9523_show(struct device *dev, mutex_lock(&st->lock); ret = ad9523_read(indio_dev, AD9523_READBACK_0); if (ret >= 0) { - ret = sprintf(buf, "%d\n", !!(ret & (1 << + ret = sysfs_emit(buf, "%d\n", !!(ret & (1 << (u32)this_attr->address))); } mutex_unlock(&st->lock);