From: Uwe Kleine-König Date: Thu, 25 May 2017 20:26:21 +0000 (+0200) Subject: mfd: twl4030-irq: Log an error in twl4030_sih_setup if the module cannot be found X-Git-Tag: v4.14-rc1~554^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=485857390927ee359a47f1c528ed6ca5725ddbc9;p=platform%2Fkernel%2Flinux-rpi.git mfd: twl4030-irq: Log an error in twl4030_sih_setup if the module cannot be found As silently failing isn't that nice, emit an error message at a place that was silent on failure up to now. Signed-off-by: Uwe Kleine-König Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index b46c0cf..378c02d 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -638,8 +638,10 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base) } } - if (status < 0) + if (status < 0) { + dev_err(dev, "module to setup SIH for not found\n"); return status; + } agent = kzalloc(sizeof(*agent), GFP_KERNEL); if (!agent)