From: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date: Thu, 16 Aug 2018 12:55:04 +0000 (+0200)
Subject: x264enc: Remove superfluous x264_param_default
X-Git-Tag: 1.16.2~45
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=484ee3e0326c3520240dc81d88c87c24df211643;p=platform%2Fupstream%2Fgst-plugins-ugly.git

x264enc: Remove superfluous x264_param_default

https://bugzilla.gnome.org/show_bug.cgi?id=796973
---

diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c
index 29bbd50d..f88cfcb7 100644
--- a/ext/x264/gstx264enc.c
+++ b/ext/x264/gstx264enc.c
@@ -133,7 +133,6 @@ struct _GstX264EncVTable
   const x264_level_t (*x264_levels)[];
   void (*x264_param_apply_fastfirstpass) (x264_param_t *);
   int (*x264_param_apply_profile) (x264_param_t *, const char *);
-  void (*x264_param_default) (x264_param_t *);
   int (*x264_param_default_preset) (x264_param_t *, const char *preset,
       const char *tune);
   int (*x264_param_parse) (x264_param_t *, const char *name, const char *value);
@@ -186,7 +185,6 @@ load_x264 (const gchar * filename)
   LOAD_SYMBOL (x264_levels);
   LOAD_SYMBOL (x264_param_apply_fastfirstpass);
   LOAD_SYMBOL (x264_param_apply_profile);
-  LOAD_SYMBOL (x264_param_default);
   LOAD_SYMBOL (x264_param_default_preset);
   LOAD_SYMBOL (x264_param_parse);
 
@@ -1520,12 +1518,6 @@ gst_x264_enc_init_encoder (GstX264Enc * encoder)
 
   g_assert (encoder->vtable != NULL);
 
-  encoder->vtable->x264_param_default (&encoder->x264param);
-  /* log callback setup; part of parameters */
-  encoder->x264param.pf_log = gst_x264_enc_log_callback;
-  encoder->x264param.p_log_private = encoder;
-  encoder->x264param.i_log_level = X264_LOG_DEBUG;
-
   gst_x264_enc_build_tunings_string (encoder);
 
   /* set x264 parameters and use preset/tuning if present */
@@ -2973,7 +2965,6 @@ plugin_init (GstPlugin * plugin)
   default_vtable.x264_param_apply_fastfirstpass =
       x264_param_apply_fastfirstpass;
   default_vtable.x264_param_apply_profile = x264_param_apply_profile;
-  default_vtable.x264_param_default = x264_param_default;
   default_vtable.x264_param_default_preset = x264_param_default_preset;
   default_vtable.x264_param_parse = x264_param_parse;