From: Mika Westerberg Date: Mon, 13 Jan 2014 09:17:04 +0000 (+0200) Subject: spi/pxa2xx: initialize DMA channels to -1 to prevent inadvertent match X-Git-Tag: v4.14-rc1~8185^2~5^7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=483c319188c74e82b29a0ed7a7fa7065570f2193;p=platform%2Fkernel%2Flinux-rpi.git spi/pxa2xx: initialize DMA channels to -1 to prevent inadvertent match Commit cddb339badb0 (spi/pxa2xx: convert to dma_request_slave_channel_compat()) converted the driver to use ACPI provided DMA helpers but it forgot to initialize the platform data for the channels to -1. Failing to do so will result inadvertent match in the filter function because 0 is a valid channel number. Prevent this from happening by initializing both platform data channels correctly to -1. Fixes: cddb339badb0 (spi/pxa2xx: convert to dma_request_slave_channel_compat()) Signed-off-by: Mika Westerberg Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index cb0e1f1..91815fa 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1066,6 +1066,8 @@ pxa2xx_spi_acpi_get_pdata(struct platform_device *pdev) pdata->num_chipselect = 1; pdata->enable_dma = true; + pdata->tx_chan_id = -1; + pdata->rx_chan_id = -1; return pdata; }