From: Roel Kluin Date: Tue, 8 Dec 2009 18:13:03 +0000 (-0500) Subject: SUNRPC: IS_ERR/PTR_ERR confusion X-Git-Tag: upstream/snapshot3+hdmi~16348^2^2~2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=480e3243df156e39eea6c91057e2ae612a6bbe19;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git SUNRPC: IS_ERR/PTR_ERR confusion IS_ERR returns 1 or 0, PTR_ERR returns the error value. Signed-off-by: Roel Kluin Cc: stable@kernel.org Signed-off-by: Trond Myklebust --- diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index fc6a43c..129d75e 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -485,7 +485,7 @@ gss_refresh_upcall(struct rpc_task *task) dprintk("RPC: %5u gss_refresh_upcall for uid %u\n", task->tk_pid, cred->cr_uid); gss_msg = gss_setup_upcall(task->tk_client, gss_auth, cred); - if (IS_ERR(gss_msg) == -EAGAIN) { + if (PTR_ERR(gss_msg) == -EAGAIN) { /* XXX: warning on the first, under the assumption we * shouldn't normally hit this case on a refresh. */ warn_gssd();