From: Kieran Bingham Date: Wed, 7 Jun 2017 09:52:07 +0000 (-0300) Subject: [media] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev X-Git-Tag: v4.14-rc1~332^2~230 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=47f910f0e0deb880c2114811f7ea1ec115a19ee4;p=platform%2Fkernel%2Flinux-rpi.git [media] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev Return NULL, if a null entity is parsed for it's v4l2_subdev Currently, the callers of media_entity_to_v4l2_subdev() need to make sure that the subdev is non-NULL, for example, when it is obtained from media_entity_remote_pad(). As this is a recurring pattern, add the check at the macro in order to avoid additional checks at the callers. Signed-off-by: Kieran Bingham Reviewed-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a407601..0f92ebd 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -826,8 +826,15 @@ struct v4l2_subdev { struct v4l2_subdev_platform_data *pdata; }; -#define media_entity_to_v4l2_subdev(ent) \ - container_of(ent, struct v4l2_subdev, entity) +#define media_entity_to_v4l2_subdev(ent) \ +({ \ + typeof(ent) __me_sd_ent = (ent); \ + \ + __me_sd_ent ? \ + container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ + NULL; \ +}) + #define vdev_to_v4l2_subdev(vdev) \ ((struct v4l2_subdev *)video_get_drvdata(vdev))