From: Souvik Kumar Chakravarty Date: Wed, 17 Feb 2016 06:35:22 +0000 (+0530) Subject: intel_telemetry_pltdrv: Change verbosity control bits X-Git-Tag: v4.6-rc1~39^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=479f3b62d6d05cf74427f61fbd92b1a54c8645aa;p=profile%2Fwearable%2Fplatform%2Fkernel%2Flinux-4.9-exynos9110.git intel_telemetry_pltdrv: Change verbosity control bits Due to a recent fix in the firmware, the Punit verbosity control bits now adhere to the correct pattern. Hence remove the workaround and do a read-modify-write of the register. Signed-off-by: Souvik Kumar Chakravarty Signed-off-by: Darren Hart --- diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c index f97019b..397119f 100644 --- a/drivers/platform/x86/intel_telemetry_pltdrv.c +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c @@ -1030,8 +1030,19 @@ static int telemetry_plt_set_trace_verbosity(enum telemetry_unit telem_unit, switch (telem_unit) { case TELEM_PSS: ret = intel_punit_ipc_command( + IPC_PUNIT_BIOS_READ_TELE_TRACE_CTRL, + 0, 0, NULL, &temp); + if (ret) { + pr_err("PSS TRACE_CTRL Read Failed\n"); + goto out; + } + + TELEM_CLEAR_VERBOSITY_BITS(temp); + TELEM_SET_VERBOSITY_BITS(temp, verbosity); + + ret = intel_punit_ipc_command( IPC_PUNIT_BIOS_WRITE_TELE_TRACE_CTRL, - 0, 0, &verbosity, NULL); + 0, 0, &temp, NULL); if (ret) { pr_err("PSS TRACE_CTRL Verbosity Set Failed\n"); goto out;