From: Gustavo A. R. Silva Date: Tue, 12 Feb 2019 18:44:50 +0000 (-0600) Subject: staging: comedi: ni_660x: fix missing break in switch statement X-Git-Tag: v5.4-rc1~1509^2~79 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=479826cc86118e0d87e5cefb3df5b748e0480924;p=platform%2Fkernel%2Flinux-rpi.git staging: comedi: ni_660x: fix missing break in switch statement Add missing break statement in order to prevent the code from falling through to the default case and return -EINVAL every time. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c index e70a461..405573e 100644 --- a/drivers/staging/comedi/drivers/ni_660x.c +++ b/drivers/staging/comedi/drivers/ni_660x.c @@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device *dev, case NI_660X_PFI_OUTPUT_DIO: if (chan > 31) return -EINVAL; + break; default: return -EINVAL; }