From: Frank Rowand <frank.rowand@sony.com>
Date: Thu, 16 Apr 2020 21:42:49 +0000 (-0500)
Subject: of: overlay: kmemleak in dup_and_fixup_symbol_prop()
X-Git-Tag: v5.15~3977^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=478ff649b1c8eb2409b1a54fb75eb46f7c29f140;p=platform%2Fkernel%2Flinux-starfive.git

of: overlay: kmemleak in dup_and_fixup_symbol_prop()

kmemleak reports several memory leaks from devicetree unittest.
This is the fix for problem 4 of 5.

target_path was not freed in the non-error path.

Fixes: e0a58f3e08d4 ("of: overlay: remove a dependency on device node full_name")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index c9219fd..50bbe0e 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -261,6 +261,8 @@ static struct property *dup_and_fixup_symbol_prop(
 
 	of_property_set_flag(new_prop, OF_DYNAMIC);
 
+	kfree(target_path);
+
 	return new_prop;
 
 err_free_new_prop: