From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 3 Nov 2012 20:30:21 +0000 (+0100)
Subject: ext3: drop if around WARN_ON
X-Git-Tag: upstream/snapshot3+hdmi~6037^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4789775477718983b6f8c604a809b950c6a10052;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

ext3: drop if around WARN_ON

Just use WARN_ON rather than an if containing only WARN_ON(1).

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 7e87e37..b176d42 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1071,8 +1071,7 @@ struct buffer_head *ext3_getblk(handle_t *handle, struct inode *inode,
 	 * mapped. 0 in case of a HOLE.
 	 */
 	if (err > 0) {
-		if (err > 1)
-			WARN_ON(1);
+		WARN_ON(err > 1);
 		err = 0;
 	}
 	*errp = err;