From: Raphael Isemann Date: Wed, 12 Feb 2020 06:57:00 +0000 (+0100) Subject: [lldb][NFC] Remove eCustomCompletion mode X-Git-Tag: llvmorg-12-init~14979 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=477c09043e654bc154fce6e6b013f8f91fb96f05;p=platform%2Fupstream%2Fllvm.git [lldb][NFC] Remove eCustomCompletion mode It's not used by anyone. Also if something implements its own completion it could just not call the method instead of having a parameter that makes the function a no-op. --- diff --git a/lldb/source/Commands/CommandCompletions.cpp b/lldb/source/Commands/CommandCompletions.cpp index 2ced56f..0e35e0d 100644 --- a/lldb/source/Commands/CommandCompletions.cpp +++ b/lldb/source/Commands/CommandCompletions.cpp @@ -29,7 +29,6 @@ using namespace lldb_private; CommandCompletions::CommonCompletionElement CommandCompletions::g_common_completions[] = { - {eCustomCompletion, nullptr}, {eSourceFileCompletion, CommandCompletions::SourceFiles}, {eDiskFileCompletion, CommandCompletions::DiskFiles}, {eDiskDirectoryCompletion, CommandCompletions::DiskDirectories}, @@ -47,9 +46,6 @@ bool CommandCompletions::InvokeCommonCompletionCallbacks( CompletionRequest &request, SearchFilter *searcher) { bool handled = false; - if (completion_mask & eCustomCompletion) - return false; - for (int i = 0;; i++) { if (g_common_completions[i].type == eNoCompletion) break;