From: Ondrej Holy Date: Mon, 20 Aug 2018 09:26:35 +0000 (+0200) Subject: core/transport: Fix leak found by covscan X-Git-Tag: 2.0.0-rc4~110^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=47595a857f093ee6e41758efe8175e425e4d1b63;p=platform%2Fupstream%2Ffreerdp.git core/transport: Fix leak found by covscan 0 is valid return value from socket(). leaked_handle: Handle variable "sockfd" going out of scope leaks the handle. --- diff --git a/libfreerdp/core/transport.c b/libfreerdp/core/transport.c index 8c1ef1f..01e8682 100644 --- a/libfreerdp/core/transport.c +++ b/libfreerdp/core/transport.c @@ -419,7 +419,7 @@ BOOL transport_connect(rdpTransport* transport, const char* hostname, else sockfd = freerdp_tcp_connect(context, settings, hostname, port, timeout); - if (sockfd < 1) + if (sockfd < 0) return FALSE; if (!transport_attach(transport, sockfd))