From: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de>
Date: Mon, 9 Oct 2006 19:27:05 +0000 (-0300)
Subject: V4L/DVB (4740): Fixed an if-block to avoid floating with debug-messages
X-Git-Tag: v2.6.20-rc1~180^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=474ce78130ba37cb50e620c538ab3ffe6c582ba6;p=platform%2Fupstream%2Fkernel-adaptation-pc.git

V4L/DVB (4740): Fixed an if-block to avoid floating with debug-messages

The dbgarg() macro in videodev.c contains some printk() statements
where only the first one is influenced by an if-statement. This causes
floating with debug-messages which is fixed by this patch by adding a
'{ ... }' pair.

Signed-off-by: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index 479a067..98de872 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -17,10 +17,11 @@
  */
 
 #define dbgarg(cmd, fmt, arg...) \
-		if (vfd->debug & V4L2_DEBUG_IOCTL_ARG)			\
+		if (vfd->debug & V4L2_DEBUG_IOCTL_ARG) {		\
 			printk (KERN_DEBUG "%s: ",  vfd->name);		\
 			v4l_printk_ioctl(cmd);				\
-			printk (KERN_DEBUG "%s: " fmt, vfd->name, ## arg);
+			printk (KERN_DEBUG "%s: " fmt, vfd->name, ## arg); \
+		}
 
 #define dbgarg2(fmt, arg...) \
 		if (vfd->debug & V4L2_DEBUG_IOCTL_ARG)			\