From: Joao Martins Date: Sat, 7 Sep 2019 23:45:24 +0000 (+0100) Subject: cpuidle-haltpoll: do not set an owner to allow modunload X-Git-Tag: v5.4-rc1~142^2~3^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=472f263660832b90e53bede2020f68cd14f8b76c;p=platform%2Fkernel%2Flinux-rpi.git cpuidle-haltpoll: do not set an owner to allow modunload cpuidle-haltpoll can be built as a module to allow optional late load. Given we are setting @owner to THIS_MODULE, cpuidle will attempt to grab a module reference every time a cpuidle_device is registered -- so essentially all online cpus get a reference. This prevents for the module to be unloaded later, which makes the module_exit callback entirely unused. Thus remove the @owner and allow module to be unloaded. Fixes: fa86ee90eb11 ("add cpuidle-haltpoll driver") Signed-off-by: Joao Martins Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c index 7a0239e..49a65c6 100644 --- a/drivers/cpuidle/cpuidle-haltpoll.c +++ b/drivers/cpuidle/cpuidle-haltpoll.c @@ -35,7 +35,6 @@ static int default_enter_idle(struct cpuidle_device *dev, static struct cpuidle_driver haltpoll_driver = { .name = "haltpoll", .governor = "haltpoll", - .owner = THIS_MODULE, .states = { { /* entry 0 is for polling */ }, {