From: Vasily Gorbik Date: Wed, 12 May 2021 17:42:10 +0000 (+0200) Subject: objtool: Fix elf_create_undef_symbol() endianness X-Git-Tag: accepted/tizen/unified/20230118.172025~7214^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=46c7405df7de8deb97229eacebcee96d61415f3f;p=platform%2Fkernel%2Flinux-rpi.git objtool: Fix elf_create_undef_symbol() endianness Currently x86 cross-compilation fails on big endian system with: x86_64-cross-ld: init/main.o: invalid string offset 488112128 >= 6229 for section `.strtab' Mark new ELF data in elf_create_undef_symbol() as symbol, so that libelf does endianness handling correctly. Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()") Signed-off-by: Vasily Gorbik Signed-off-by: Ingo Molnar Acked-by: Peter Zijlstra Link: https://lore.kernel.org/r/patch-1.thread-6c9df9.git-d39264656387.your-ad-here.call-01620841104-ext-2554@work.hours --- diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index d08f5f3..743c2e9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -762,6 +762,7 @@ struct symbol *elf_create_undef_symbol(struct elf *elf, const char *name) data->d_buf = &sym->sym; data->d_size = sizeof(sym->sym); data->d_align = 1; + data->d_type = ELF_T_SYM; sym->idx = symtab->len / sizeof(sym->sym);