From: H Hartley Sweeten Date: Wed, 7 Oct 2015 00:23:39 +0000 (-0700) Subject: staging: comedi: me_daq: remove useless for() loop X-Git-Tag: v4.14-rc1~4420^2~852 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=46ada8afc8fdd2788db152ceb0fc001f46072dfe;p=platform%2Fkernel%2Flinux-rpi.git staging: comedi: me_daq: remove useless for() loop This for() loop isn't needed. Nothing in the loop uses the 'i' variable. Remove it. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c index 71188fb..a2b542e 100644 --- a/drivers/staging/comedi/drivers/me_daq.c +++ b/drivers/staging/comedi/drivers/me_daq.c @@ -319,15 +319,12 @@ static int me_ao_insn_write(struct comedi_device *dev, writew(devpriv->ctrl2, dev->mmio + ME_CTRL2_REG); /* Set dac-control register */ - for (i = 0; i < insn->n; i++) { - /* clear bits for this channel */ - devpriv->dac_ctrl &= ~ME_DAC_CTRL_MASK(chan); - if (range == 0) - devpriv->dac_ctrl |= ME_DAC_CTRL_GAIN(chan) | - ME_DAC_CTRL_BIPOLAR(chan); - else if (range == 1) - devpriv->dac_ctrl |= ME_DAC_CTRL_BIPOLAR(chan); - } + devpriv->dac_ctrl &= ~ME_DAC_CTRL_MASK(chan); + if (range == 0) + devpriv->dac_ctrl |= ME_DAC_CTRL_GAIN(chan) | + ME_DAC_CTRL_BIPOLAR(chan); + else if (range == 1) + devpriv->dac_ctrl |= ME_DAC_CTRL_BIPOLAR(chan); writew(devpriv->dac_ctrl, dev->mmio + ME_DAC_CTRL_REG); /* Update dac-control register */