From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Wed, 28 Jul 2021 01:49:25 +0000 (+0800)
Subject: nfc: s3fwrn5: fix undefined parameter values in dev_err()
X-Git-Tag: v5.15~630^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=46573e3ab08fb041d5ba7bf7bf3215a1e724c78c;p=platform%2Fkernel%2Flinux-starfive.git

nfc: s3fwrn5: fix undefined parameter values in dev_err()

In the function s3fwrn5_fw_download(), the 'ret' is not assigned,
so the correct value should be given in dev_err function.

Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index 1340fab..e3e72b8 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc/s3fwrn5/firmware.c
@@ -423,7 +423,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info)
 	if (IS_ERR(tfm)) {
 		ret = PTR_ERR(tfm);
 		dev_err(&fw_info->ndev->nfc_dev->dev,
-			"Cannot allocate shash (code=%ld)\n", PTR_ERR(tfm));
+			"Cannot allocate shash (code=%pe)\n", tfm);
 		goto out;
 	}