From: hermet Date: Tue, 21 Feb 2012 01:53:40 +0000 (+0000) Subject: elementary/font - reviewed my reviewed code... ;-) X-Git-Tag: REL_F_I9500_20120323_1~17^2~629 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=45fb0a8be7307bbbd573f84bd5ba17a86a2a16d8;p=framework%2Fuifw%2Felementary.git elementary/font - reviewed my reviewed code... ;-) git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@68181 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- diff --git a/src/lib/elm_font.c b/src/lib/elm_font.c index 372117a..fa5f85a 100644 --- a/src/lib/elm_font.c +++ b/src/lib/elm_font.c @@ -33,7 +33,7 @@ _elm_font_properties_get(Eina_Hash **font_hash, { len = s2 - name; name = realloc(name, sizeof(char) * len + 1); - if (!name) + if (name) { memset(name, 0, sizeof(char) * len + 1); strncpy(name, font, len); @@ -51,10 +51,9 @@ _elm_font_properties_get(Eina_Hash **font_hash, if (efp) { efp->name = eina_stringshare_add(name); - if (font_hash) + if ((font_hash && !*font_hash)) { - if (!*font_hash) - *font_hash = eina_hash_string_superfast_new(NULL); + *font_hash = eina_hash_string_superfast_new(NULL); eina_hash_add(*font_hash, name, efp); } } @@ -90,10 +89,9 @@ _elm_font_properties_get(Eina_Hash **font_hash, if (efp) { efp->name = eina_stringshare_add(font); - if (font_hash) + if (font_hash && !*font_hash) { - if (!*font_hash) - *font_hash = eina_hash_string_superfast_new(NULL); + *font_hash = eina_hash_string_superfast_new(NULL); eina_hash_add(*font_hash, font, efp); } }