From: Santiago Fernandez Madero Date: Fri, 10 Jul 2020 05:57:22 +0000 (-0700) Subject: WASM Re-enable Threading.Channels serialization tests (#39016) X-Git-Tag: submit/tizen/20210909.063632~6821 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=45bd3f9a706d5b57f7c3f16cd9ff802d8ea25744;p=platform%2Fupstream%2Fdotnet%2Fruntime.git WASM Re-enable Threading.Channels serialization tests (#39016) * WASM Re-enable Threading.Channels serialization tests * PR Feedback * Use ConditionalFact --- diff --git a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs index e4b7ec9..a96c217 100644 --- a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs +++ b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs @@ -42,6 +42,8 @@ namespace System public static bool IsNotWindows => !IsWindows; public static bool IsThreadingSupported => !IsBrowser; + public static bool IsBinaryFormatterSupported => !IsBrowser; + // Please make sure that you have the libgdiplus dependency installed. // For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus public static bool IsDrawingSupported diff --git a/src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs b/src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs index 0fde76e..70eca33 100644 --- a/src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs +++ b/src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs @@ -9,8 +9,7 @@ namespace System.Threading.Channels.Tests { public partial class ChannelClosedExceptionTests { - [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/37648", TestPlatforms.Browser)] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] public void Serialization_Roundtrip() { var s = new MemoryStream();