From: Johan Hovold Date: Tue, 13 Oct 2015 17:10:26 +0000 (+0200) Subject: greybus: protocol: make version debug message more informative X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1137 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4505c4d44a660866f2006eacafcb8c7d182ec182;p=platform%2Fkernel%2Flinux-rpi.git greybus: protocol: make version debug message more informative Include function, protocol name and id when printing the version response debug message. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/protocol.c b/drivers/staging/greybus/protocol.c index b9de152..41190e8 100644 --- a/drivers/staging/greybus/protocol.c +++ b/drivers/staging/greybus/protocol.c @@ -155,10 +155,11 @@ int gb_protocol_get_version(struct gb_connection *connection) { struct gb_protocol_version_request request; struct gb_protocol_version_response response; + struct gb_protocol *protocol = connection->protocol; int retval; - request.major = connection->protocol->major; - request.minor = connection->protocol->minor; + request.major = protocol->major; + request.minor = protocol->minor; retval = gb_operation_sync(connection, GB_REQUEST_TYPE_PROTOCOL_VERSION, &request, sizeof(request), &response, @@ -176,8 +177,10 @@ int gb_protocol_get_version(struct gb_connection *connection) connection->module_major = response.major; connection->module_minor = response.minor; - dev_dbg(&connection->dev, "version_major = %u version_minor = %u\n", - response.major, response.minor); + + dev_dbg(&connection->dev, "%s - %s (0x%02hhx) v%hhu.%hhu\n", __func__, + protocol->name, protocol->id, + response.major, response.minor); return 0; }