From: Daniel Juyung Seo <juyung.seo@samsung.com>
Date: Mon, 23 Dec 2013 05:49:50 +0000 (+0900)
Subject: theme: Check the return value of _elm_theme_group_file_find() and do not
X-Git-Tag: v1.9.0-alpha1~375
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44e97a3bfa4df727ca360e359f2b4f0372f12f6b;p=platform%2Fupstream%2Felementary.git

theme: Check the return value of _elm_theme_group_file_find() and do not
pass NULL to eina_file_filename_get().

eina_file_filename_get() spits unnecessary eina error when the parameter
is null. In this case, we need to check the return of
_elm_theme_group_file_find() and do not call eina_file_filename_get()
	when the return is null. One should check the return of
	elm_theme_group_path_find().
Thank zmike for pointing this out.
---

diff --git a/src/lib/elm_theme.c b/src/lib/elm_theme.c
index 7dea91e..914849d 100644
--- a/src/lib/elm_theme.c
+++ b/src/lib/elm_theme.c
@@ -856,8 +856,13 @@ EAPI const char *
 elm_theme_group_path_find(Elm_Theme *th, const char *group)
 {
    EINA_SAFETY_ON_NULL_RETURN_VAL(group, NULL);
+   Eina_File *th_file = NULL;
    if (!th) th = &(theme_default);
-   return eina_file_filename_get(_elm_theme_group_file_find(th, group));
+
+   th_file = _elm_theme_group_file_find(th, group);
+   if (th_file)
+     return eina_file_filename_get(th_file);
+   return NULL;
 }
 
 static Eina_List *