From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Date: Fri, 30 Jun 2023 11:23:07 +0000 (+0400)
Subject: fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/
X-Git-Tag: v6.6.7~2396^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44b4494d5c5971dc8f531c8783d90a637e862880;p=platform%2Fkernel%2Flinux-starfive.git

fs/ntfs3: Correct mode for label entry inside /proc/fs/ntfs3/

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
---

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index e36769e..1a02072 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1548,11 +1548,12 @@ load_root:
 	/* Create /proc/fs/ntfs3/.. */
 	if (proc_info_root) {
 		struct proc_dir_entry *e = proc_mkdir(sb->s_id, proc_info_root);
+		static_assert((S_IRUGO | S_IWUSR) == 0644);
 		if (e) {
-			proc_create_data("volinfo", S_IFREG | S_IRUGO, e,
+			proc_create_data("volinfo", S_IRUGO, e,
 					 &ntfs3_volinfo_fops, sb);
-			proc_create_data("label", S_IFREG | S_IRUGO | S_IWUGO,
-					 e, &ntfs3_label_fops, sb);
+			proc_create_data("label", S_IRUGO | S_IWUSR, e,
+					 &ntfs3_label_fops, sb);
 			sbi->procdir = e;
 		}
 	}