From: Kulikov Vasiliy <segooon@gmail.com>
Date: Wed, 11 Aug 2010 01:03:19 +0000 (-0700)
Subject: edac: i5000: improve handling of pci_enable_device() return value
X-Git-Tag: upstream/snapshot3+hdmi~13344
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44aa80f005be88fef940fccdd345b313964768f3;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

edac: i5000: improve handling of pci_enable_device() return value

-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future.  We should compare return
code with zero, not with concrete error value.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jeff Roberson <jroberson@jroberson.net>
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 996c1bd..a5cefab 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -1482,7 +1482,7 @@ static int __devinit i5000_init_one(struct pci_dev *pdev,
 
 	/* wake up device */
 	rc = pci_enable_device(pdev);
-	if (rc == -EIO)
+	if (rc)
 		return rc;
 
 	/* now probe and enable the device */