From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Nov 2011 22:12:27 +0000 (-0500)
Subject: sfc: fix race in efx_enqueue_skb_tso()
X-Git-Tag: v3.3-rc1~182^2~402
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=449fa023bca5b53bd924d91a27ffd34807fdeb80;p=profile%2Fivi%2Fkernel-x86-ivi.git

sfc: fix race in efx_enqueue_skb_tso()

As soon as skb is pushed to hardware, it can be completed and freed, so
we should not dereference skb anymore.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
index ab4c635..e0e00b3 100644
--- a/drivers/net/ethernet/sfc/tx.c
+++ b/drivers/net/ethernet/sfc/tx.c
@@ -1173,11 +1173,11 @@ static int efx_enqueue_skb_tso(struct efx_tx_queue *tx_queue,
 			goto mem_err;
 	}
 
+	netdev_tx_sent_queue(tx_queue->core_txq, skb->len);
+
 	/* Pass off to hardware */
 	efx_nic_push_buffers(tx_queue);
 
-	netdev_tx_sent_queue(tx_queue->core_txq, skb->len);
-
 	tx_queue->tso_bursts++;
 	return NETDEV_TX_OK;