From: Liping Zhang <zlpnobody@gmail.com>
Date: Wed, 15 Mar 2017 14:22:08 +0000 (+0800)
Subject: netfilter: nft_ct: do cleanup work when NFTA_CT_DIRECTION is invalid
X-Git-Tag: v5.15~11641^2~55^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4494dbc6dec37817f2cc2aa7604039a9e87ada18;p=platform%2Fkernel%2Flinux-starfive.git

netfilter: nft_ct: do cleanup work when NFTA_CT_DIRECTION is invalid

We should jump to invoke __nft_ct_set_destroy() instead of just
return error.

Fixes: edee4f1e9245 ("netfilter: nft_ct: add zone id set support")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
index 91585b5..0264258 100644
--- a/net/netfilter/nft_ct.c
+++ b/net/netfilter/nft_ct.c
@@ -544,7 +544,8 @@ static int nft_ct_set_init(const struct nft_ctx *ctx,
 		case IP_CT_DIR_REPLY:
 			break;
 		default:
-			return -EINVAL;
+			err = -EINVAL;
+			goto err1;
 		}
 	}