From: Tobias Jakobi Date: Fri, 5 Sep 2014 05:19:48 +0000 (+0200) Subject: usb3503: clarify what the registers 'PDS' and 'CFG1' really do X-Git-Tag: v4.14-rc1~6740^2~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4463e1526780ad1c4a15ef5d68cdc19315303d44;p=platform%2Fkernel%2Flinux-rpi.git usb3503: clarify what the registers 'PDS' and 'CFG1' really do The current comment sounds like you have to disable some of the ports to be able to use self-powered mode. This is misleading, so change the wording to reflect this. Signed-off-by: Tobias Jakobi Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index 0819a2e..ae7e120 100644 --- a/drivers/usb/misc/usb3503.c +++ b/drivers/usb/misc/usb3503.c @@ -98,7 +98,7 @@ static int usb3503_connect(struct usb3503 *hub) return err; } - /* PDS : Disable For Self Powered Operation */ + /* PDS : Set the ports which are disabled in self-powered mode. */ if (hub->port_off_mask) { err = regmap_update_bits(hub->regmap, USB3503_PDS, hub->port_off_mask, @@ -109,7 +109,7 @@ static int usb3503_connect(struct usb3503 *hub) } } - /* CFG1 : SELF_BUS_PWR -> Self-Powerd operation */ + /* CFG1 : Set SELF_BUS_PWR, this enables self-powered operation. */ err = regmap_update_bits(hub->regmap, USB3503_CFG1, USB3503_SELF_BUS_PWR, USB3503_SELF_BUS_PWR);