From: Simon Marchi Date: Mon, 2 May 2016 17:10:33 +0000 (-0400) Subject: Fix detach.exp remote check X-Git-Tag: binutils-2_27~610 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=444e826c911693e6dad1cf907d81eb9dc1bef7d2;p=external%2Fbinutils.git Fix detach.exp remote check This test seems to work with both native-gdbserver and native-extended-gdbserver, so I removed the remote check. When running with native-gdbserver (a stub-like target), detach makes gdbserver stop and gdb disconnect. runto_main just spawns a brand new gdbserver. So it tests the exact same thing twice. It doesn't hurt though. With native-extended-gdbserver, the test is probably a bit more useful (and similar to native). It tests running/detaching twice using the same gdb/gdbserver instances, since with extended-remote, you can detach/attach/run all you want, unlike with remote. gdb/testsuite/ChangeLog: * gdb.base/detach.exp: Remove is_remote check. --- diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fb6538c..6d34da6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2016-05-02 Simon Marchi + * gdb.base/detach.exp: Remove is_remote check. + +2016-05-02 Simon Marchi + * gdb.base/annota-input-while-running.exp: Don't check for [is_remote target]. Enable annotations after running to main. Remove unused "set test..." line. diff --git a/gdb/testsuite/gdb.base/detach.exp b/gdb/testsuite/gdb.base/detach.exp index 920dac2..b9343ee 100644 --- a/gdb/testsuite/gdb.base/detach.exp +++ b/gdb/testsuite/gdb.base/detach.exp @@ -22,11 +22,6 @@ if { ! [istarget "*-*-linux*"] } { return 0 } -# Are we on a target board? -if [is_remote target] then { - return 0 -} - standard_testfile attach.c set escapedbinfile [string_to_regexp ${binfile}]