From: Dan Rosenberg Date: Wed, 15 Sep 2010 11:43:04 +0000 (+0000) Subject: drivers/net/eql.c: prevent reading uninitialized stack memory X-Git-Tag: v2.6.36-rc5~12^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44467187dc22fdd33a1a06ea0ba86ce20be3fe3c;p=platform%2Fupstream%2Fkernel-adaptation-pc.git drivers/net/eql.c: prevent reading uninitialized stack memory Fixed formatting (tabs and line breaks). The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of the master_config_t struct declared on the stack in eql_g_master_cfg() is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg Signed-off-by: David S. Miller --- diff --git a/drivers/net/eql.c b/drivers/net/eql.c index dda2c79..0cb1cf9 100644 --- a/drivers/net/eql.c +++ b/drivers/net/eql.c @@ -555,6 +555,8 @@ static int eql_g_master_cfg(struct net_device *dev, master_config_t __user *mcp) equalizer_t *eql; master_config_t mc; + memset(&mc, 0, sizeof(master_config_t)); + if (eql_is_master(dev)) { eql = netdev_priv(dev); mc.max_slaves = eql->max_slaves;