From: Lee Jones Date: Fri, 26 Jun 2020 06:57:35 +0000 (+0100) Subject: regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() X-Git-Tag: v5.15~2854^2~47 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44455a6d3bcab53ae8330a009d513ade0f12c0c0;p=platform%2Fkernel%2Flinux-starfive.git regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Until now the aforementioned return value has been ignored. Previous and current calls to tps65217_reg_read() return instantly when the value is not 0, so let's do that. Fixes the following W=1 warning: drivers/regulator/tps65217-regulator.c: In function ‘tps65217_regulator_probe’: drivers/regulator/tps65217-regulator.c:227:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 227 | int i, ret; | ^~~ Signed-off-by: Lee Jones Cc: Russ Dill Cc: Keerthy Cc: AnilKumar Ch Cc: linux-omap@vger.kernel.org Link: https://lore.kernel.org/r/20200626065738.93412-7-lee.jones@linaro.org Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c index f2d3a4a..3f5ea02 100644 --- a/drivers/regulator/tps65217-regulator.c +++ b/drivers/regulator/tps65217-regulator.c @@ -254,6 +254,9 @@ static int tps65217_regulator_probe(struct platform_device *pdev) /* Store default strobe info */ ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); + if (ret) + return ret; + tps->strobes[i] = val & regulators[i].bypass_mask; }