From: Armin Novak <armin.novak@thincast.com>
Date: Thu, 11 Jul 2019 09:44:18 +0000 (+0200)
Subject: Don't set ACCESS_DENIED on first HTTP gateway response.
X-Git-Tag: 2.0.0~430^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4435fc843006503316ab1ec2990e796ae453eaf9;p=platform%2Fupstream%2Ffreerdp.git

Don't set ACCESS_DENIED on first HTTP gateway response.

The first response is alwasy ACCESS_DENIED to initiate authentication.
Only the second response must not have that status.
---

diff --git a/libfreerdp/core/gateway/rdg.c b/libfreerdp/core/gateway/rdg.c
index 62161a7..498bc23 100644
--- a/libfreerdp/core/gateway/rdg.c
+++ b/libfreerdp/core/gateway/rdg.c
@@ -1052,11 +1052,6 @@ static BOOL rdg_establish_data_connection(rdpRdg* rdg, rdpTls* tls,
 
 		switch(StatusCode)
 		{
-			case HTTP_STATUS_DENIED:
-				freerdp_set_last_error(rdg->context, FREERDP_ERROR_CONNECT_ACCESS_DENIED);
-				http_response_free(response);
-				return FALSE;
-
 			case HTTP_STATUS_NOT_FOUND:
 			{
 				WLog_INFO(TAG, "RD Gateway does not support HTTP transport.");
@@ -1101,9 +1096,9 @@ static BOOL rdg_establish_data_connection(rdpRdg* rdg, rdpTls* tls,
 		case HTTP_STATUS_DENIED:
 			freerdp_set_last_error(rdg->context, FREERDP_ERROR_CONNECT_ACCESS_DENIED);
 			return FALSE;
-			default:
-				return FALSE;
-		}
+		default:
+			return FALSE;
+	}
 
 	if (strcmp(method, "RDG_OUT_DATA") == 0)
 	{