From: Radim Krčmář Date: Fri, 6 Oct 2017 17:25:55 +0000 (+0200) Subject: KVM: x86: thoroughly disarm LAPIC timer around TSC deadline switch X-Git-Tag: v4.19~2163^2~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=44275932589a84a24849290b0d5c22157016a5e6;p=platform%2Fkernel%2Flinux-rpi.git KVM: x86: thoroughly disarm LAPIC timer around TSC deadline switch Our routines look at tscdeadline and period when deciding state of a timer. The timer is disarmed when switching between TSC deadline and other modes, so we should set everything to disarmed state. Signed-off-by: Radim Krčmář Reviewed-by: Wanpeng Li Signed-off-by: Paolo Bonzini --- diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 96ade84..a778f1ae 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -1330,8 +1330,10 @@ static void apic_update_lvtt(struct kvm_lapic *apic) if (apic->lapic_timer.timer_mode != timer_mode) { if (apic_lvtt_tscdeadline(apic) != (timer_mode == APIC_LVT_TIMER_TSCDEADLINE)) { - kvm_lapic_set_reg(apic, APIC_TMICT, 0); hrtimer_cancel(&apic->lapic_timer.timer); + kvm_lapic_set_reg(apic, APIC_TMICT, 0); + apic->lapic_timer.period = 0; + apic->lapic_timer.tscdeadline = 0; } apic->lapic_timer.timer_mode = timer_mode; limit_periodic_timer_frequency(apic);